| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Rahila Syed <rahilasyed90(at)gmail(dot)com> |
| Subject: | Re: pgsql: Add function to get memory context stats for processes |
| Date: | 2025-04-23 18:14:34 |
| Message-ID: | 1428549.1745432074@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> My primary concern about the patch is that
> ProcessGetMemoryContextInterrupt() can be called from any
> CHECK_FOR_INTERRUPTS() and calls lots of DSA functions, including
> dsa_create() and, via PublishMemoryContext(), dsa_allocate0(). I'm
> shocked to hear that you and Andres think that's safe to do at any
> current or future CHECK_FOR_INTERRUPTS() anywhere in the code; but
> Andres seems very confident that it's fine, so perhaps I should just
> stop worrying and be happy that we have the feature.
Just for the record, it sounds quite unsafe to me too. I could
credit it being all right to examine the process' MemoryContext data
structures, but calling dsa_create() from CFI seems really insane.
Way too many moving parts there.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2025-04-23 20:02:36 | pgsql: oauth: Support Python 3.6 in tests |
| Previous Message | Alexander Korotkov | 2025-04-23 17:27:39 | pgsql: Maintain RelIdToTypeIdCacheHash in TypeCacheOpcCallback() |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-04-23 19:42:53 | Re: [PATCH] dynahash: add memory allocation failure check |
| Previous Message | Jacob Champion | 2025-04-23 17:46:14 | Re: [PoC] Federated Authn/z with OAUTHBEARER |