Re: [PATCH] Cleanup of GUC units code

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Greg Stark" <stark(at)enterprisedb(dot)com>
Cc: "Simon Riggs" <simon(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "Heikki Linnakangas" <heikki(dot)linnakangas(at)enterprisedb(dot)com>, "Marko Kreen" <markokr(at)gmail(dot)com>, "Peter Eisentraut" <peter_e(at)gmx(dot)net>, "Asko Oja" <ascoja(at)gmail(dot)com>
Subject: Re: [PATCH] Cleanup of GUC units code
Date: 2008-09-08 14:10:44
Message-ID: 14276.1220883044@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Greg Stark" <stark(at)enterprisedb(dot)com> writes:
> On Mon, Sep 8, 2008 at 2:11 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> But of course case insensitivity isn't going to fix that example for you.
>> So we're right back at the question of where we should draw the line in
>> trying to accept variant input.

> Well it's not a perfect precedent but for example, dd accepts:

> G (2^30)
> M (2^20)
> k (2^10)
> K (2^10)
> Kb (10^3)
> MB (10^6)
> GB (10^9)
> b (512)

Hmm. I could get behind a proposal to allow single-letter abbreviations
if it could be made to work across the board, but what about the time
units? "ms" vs "min" is the sticky part there...

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Sabino Mullane 2008-09-08 14:15:14 Re: [PATCH] Cleanup of GUC units code
Previous Message Tom Lane 2008-09-08 14:05:50 Re: reducing statistics write overhead