Re: Quick patch: Display sequence owner

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Josh Williams <joshwilliams(at)ij(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Quick patch: Display sequence owner
Date: 2008-12-09 14:32:19
Message-ID: 14270.1228833139@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Josh Williams wrote:
>> The patch adds a query against pg_depend, then fakes an extra column
>> "owned_by" in the output:

> Please send a context diff (diff -c)

Don't bother --- it's a really bad idea as designed anyway. owned_by
is not a column of a sequence relation and pretending that it is one
will just cause confusion.

I think the place that such information could most naturally be squeezed
into psql's \d commands would be to add another type of footer
information to \dt, eg

Table "foo.bar"
...
Indexes:
"bari" ...
Owned sequences:
"baz" owned by col1
...

If you really want to attach the information to the \d output for the
sequence instead of the table, consider a similar footer-style display
instead of making it look like something it's not.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Chernow 2008-12-09 14:34:54 Re: new libpq SSL connection option
Previous Message Heikki Linnakangas 2008-12-09 14:29:18 Re: Multiplexing SUGUSR1