| From: | Jozef Mlich <jmlich(at)redhat(dot)com> |
|---|---|
| To: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | shebang for tcl postgresql modules |
| Date: | 2015-03-12 10:17:01 |
| Message-ID: | 1426155421.2535.11.camel@redhat.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear hackers,
I would like to ask you if is there any reason to pretend tcl scripts
are shell scripts?
I am speaking namely about these files
http://git.postgresql.org/gitweb/?p=postgresql.git;a=blob_plain;f=src/pl/tcl/modules/pltcl_delmod.in;hb=HEAD
http://git.postgresql.org/gitweb/?p=postgresql.git;a=blob_plain;f=src/pl/tcl/modules/pltcl_listmod.in;hb=HEAD
http://git.postgresql.org/gitweb/?p=postgresql.git;a=blob_plain;f=src/pl/tcl/modules/pltcl_loadmod.in;hb=HEAD
Here is the part of code I am speaking about:
#! /bin/sh
# Start tclsh \
exec @TCLSH@ "$0" "$@"
instead of
#! /usr/bin/tclsh
or
#! @TCLSH@
I am asking because our test suite is triggering errors on this [1]. In
this case, it seems easier to modify code rather then test suite. Please
apply attached patch if there is no particular reason for use
of /bin/sh.
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1199464
--
Jozef Mlich <jmlich(at)redhat(dot)com>
Associate Software Engineer - EMEA ENG Developer Experience
Mobile: +420 604 217 719
http://cz.redhat.com/
Red Hat, Inc.
| Attachment | Content-Type | Size |
|---|---|---|
| tcl-shebang.patch | text/x-patch | 1.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2015-03-12 10:52:25 | Re: Parallel Seq Scan |
| Previous Message | Andres Freund | 2015-03-12 09:41:08 | Re: Turning off HOT/Cleanup sometimes |