From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Brendan Jurd <direvus(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Bytea as C string in pg_convert? |
Date: | 2007-09-24 15:17:11 |
Message-ID: | 14238.1190647031@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> I have changed it. The thing is, though, that this function not only
> performs the convert() function but acts as the engine for convert_to()
> and convert_from(). Those functions do some silent transformations, in
> one case passing a text Datum as the first argument and in the other
> case the returning the result as text. If there's a better way to do
> this I'll be happy to learn, but it seems to me it would involve some
> duplication - I tried to avoid that where possible.
Hmm. One suggestion would be to have an internal function declared
as taking and returning "struct varlena *", with a comment saying that
we depend on text and bytea both being compatible with this. All three
SQL-visible functions are then thin wrappers around that.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2007-09-24 15:26:54 | Re: [COMMITTERS] pgsql: Reduce the size of memoryallocations by lazy vacuum when |
Previous Message | Andrew Dunstan | 2007-09-24 15:07:17 | Re: Bytea as C string in pg_convert? |