Re: CURRENT/OLD keywords still broken

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: CURRENT/OLD keywords still broken
Date: 2000-12-15 23:15:07
Message-ID: 14176.976922107@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> That was me. The old code did old -> current, so I changed it to do
> current -> old. How else can I fix this? Attached is the old patch.

But CURRENT was strictly an internal token name, not a string the user
could actually see. So there's no need to have
+ /* for portability with old rules bjm 2000-06-12 */
+ {"current", OLD},

The only way that there would be a compatibility problem would be if
ruleutils.c had been set up to print CURRENT, but it wasn't:

*** 1278,1284 ****
quote_identifier(rte->relname));
else if (!strcmp(rte->ref->relname, "*NEW*"))
appendStringInfo(buf, "new.");
! else if (!strcmp(rte->ref->relname, "*CURRENT*"))
appendStringInfo(buf, "old.");
else
appendStringInfo(buf, "%s.",
--- 1278,1284 ----
quote_identifier(rte->relname));
else if (!strcmp(rte->ref->relname, "*NEW*"))
appendStringInfo(buf, "new.");
! else if (!strcmp(rte->ref->relname, "*OLD*"))
appendStringInfo(buf, "old.");
else

NEW and OLD are what the user see, and have been for awhile. So there's
no compatibility issue here.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Oliver Elphick 2000-12-15 23:31:41 Re: 7.1 (current) unwanted NOT NULL constraint inserted
Previous Message Tom Lane 2000-12-15 23:09:33 Re: Views as FROM subselects