| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: SIGQUIT handling, redux |
| Date: | 2020-09-09 23:24:55 |
| Message-ID: | 141736.1599693895@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Here's a draft patch that I think would be reasonable to back-patch.
(Before v13, we'd need a bespoke SIGQUIT handler to substitute for
SignalHandlerForCrashExit, but that's easy enough.)
Aside from comment updates, this
* uses SignalHandlerForCrashExit for SIGQUIT
* renames startup_die per your request
* moves BackendInitialize's interrupt-re-disabling code up a bit to
reduce the scope where these interrupts are active. This doesn't
make things a whole lot safer, but it can't hurt.
I'll take a closer look at the idea of using _exit(1) tomorrow,
but I'd be pretty hesitant to back-patch that.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| safer-startup-packet-signals-1.patch | text/x-diff | 6.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | tsunakawa.takay@fujitsu.com | 2020-09-10 01:13:08 | RE: Transactions involving multiple postgres foreign servers, take 2 |
| Previous Message | Justin Pryzby | 2020-09-09 23:07:00 | Re: v13: show extended stats target in \d |