Re: pgsql: Message improvements

From: David G Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>
To: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Message improvements
Date: 2014-11-12 02:26:48
Message-ID: 1415759208069-5826612.post@n5.nabble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

A couple of minor observations:

The new wording for this one seems worse off:

> incomplete read from reorderbuffer spill file: read %d instead of %u bytes

The "incomplete" aspect seems to be material...the proposed wording leads
one to believe the file is unreadable for some reason and then goes on to
say that bytes were read.

how about:

incomplete read of reorderbuffer spill file: read %d of expected %u bytes

> Writes full pages to WAL when first modified after a checkpoint, even for
> a non-critical modifications.

"... even for non-critical modifications." -- drop the "a" since
modifications is plural (or make it singular)

David J.

--
View this message in context: http://postgresql.nabble.com/pgsql-Message-improvements-tp5826611p5826612.html
Sent from the PostgreSQL - committers mailing list archive at Nabble.com.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2014-11-12 12:36:50 pgsql: Use just one database connection in the "tablespace" test.
Previous Message Peter Eisentraut 2014-11-12 01:44:06 pgsql: Message improvements