Re: Hash index creation warning

From: David G Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Hash index creation warning
Date: 2014-10-17 16:43:38
Message-ID: 1413564218693-5823445.post@n5.nabble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote
> Now that we have the create hash index warning in 9.5, I realized that
> we don't warn about hash indexes with PITR, only crash recovery and
> streaming. This patch fixes that.
>
> Is the wording "cannot be used" too vague. The CREATE INDEX manual
> page has the words "give wrong answers to queries", which might be
> better, but is kind of long for an error message. Suggestions?

Something like the following is more specific without being more wordy:

"hash indexes are not WAL-logged: they are corrupted during recovery and
changes do not replicate to standby servers."

The question is whether we explain the implications of not being WAL-logged
in an error message or simply state the fact and let the documentation
explain the hazards - basically just output:

"hash indexes are not WAL-logged and their use is discouraged"

David J.

--
View this message in context: http://postgresql.1045698.n5.nabble.com/Hash-index-creation-warning-tp5823443p5823445.html
Sent from the PostgreSQL - hackers mailing list archive at Nabble.com.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-10-17 16:50:38 Re: [Segmentation fault] pg_dump binary-upgrade fail for type without element
Previous Message Alvaro Herrera 2014-10-17 16:40:21 Re: [PATCH] add ssl_protocols configuration option