| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Check for GiST index tuples that don't fit on a page. |
| Date: | 2014-10-07 00:33:41 |
| Message-ID: | 1412642021.30485.17.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Sun, 2014-10-05 at 10:06 +0300, Heikki Linnakangas wrote:
> Hmm. For this particular case, it would straightforward to add a step to
> the buildfarm script to do "grep -r '%z' src". It might turn up false
> positives, if there's a %z in comments or such, but it shouldn't be much
> effort to maintain a list of exceptions to filter out the false positives.
The problem in this case was that a change was backpatched that doesn't
always work in back branches, but works fine in master. The check you
describe would only have worked if somehow we'd have added it at the
time %z support was added to master, with tremendous foresight. Plus,
you don't really want to get into the habit of backpatching more ways
the build could fail in stable branches.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-10-07 01:24:35 | pgsql: Fix array overrun in ecpg's version of ParseDateTime(). |
| Previous Message | Peter Eisentraut | 2014-10-07 00:25:52 | Re: pgsql: Check for GiST index tuples that don't fit on a page. |