From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Thomas Kellerer <spam_eater(at)gmx(dot)net>, pgsql-general(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [HACKERS] pg_upgrade from 9.5 to 9.6 fails with "invalid argument" |
Date: | 2016-09-29 21:51:53 |
Message-ID: | 14048.1475185913@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Moreover I think getErrorText() as a whole is misconceived and should be
> removed altogether (why pstrdup the string?).
Indeed. I think bouncing the error back to the caller is misguided
to start with, seeing that the caller is just going to do pg_fatal
anyway. We should rewrite these functions to just error out internally,
which will make it much easier to provide decent error reporting
indicating which call failed.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-09-29 22:08:53 | Re: [GENERAL] pg_upgrade from 9.5 to 9.6 fails with "invalid argument" |
Previous Message | Tom Lane | 2016-09-29 21:48:30 | Re: [GENERAL] pg_upgrade from 9.5 to 9.6 fails with "invalid argument" |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-09-29 21:53:22 | Re: pg_basebackup, pg_receivexlog and data durability (was: silent data loss with ext4 / all current versions) |
Previous Message | Tom Lane | 2016-09-29 21:48:30 | Re: [GENERAL] pg_upgrade from 9.5 to 9.6 fails with "invalid argument" |