Re: pgsql: Create an improved FDW option validator function for contrib/dbl

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Create an improved FDW option validator function for contrib/dbl
Date: 2012-10-11 00:07:52
Message-ID: 14047.1349914072@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 10/10/2012 04:53 PM, Tom Lane wrote:
>> Create an improved FDW option validator function for contrib/dblink.

> This seems to have broken a bunch of buildfarm members.

Oh, yuck. It looks like the problem is that the list of allowed
connection options varies depending on configure options.

I think the best solution is to take out the test cases that trigger
those errors. It's not like they're telling us anything very interesting.

Will fix, thanks for the heads-up.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2012-10-11 00:14:35 pgsql: Remove configure-option-dependent test cases from dblink tests.
Previous Message Andrew Dunstan 2012-10-10 23:58:36 Re: pgsql: Create an improved FDW option validator function for contrib/dbl