Re: explain root element for auto-explain

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: explain root element for auto-explain
Date: 2009-08-20 14:47:04
Message-ID: 14046.1250779624@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> I have a couple of questions, however. First, in that long list of
> alternatives for a Plan node, can any of them occur more than once?

No.

> Second, we are using Item as a child of both Output and Sort-Key nodes.
> Are they really describing the same thing? And in any case, Item is a
> wonderfully non-informative name, as is Output, for that matter.

They are both describing expressions. I wanted to rename Item as Expr,
if you'll recall. But I think we should have a concrete plan about
all the tweaks we want to make to the output schema before doing
anything, so I haven't pushed to change it immediately.

I don't see anything wrong with Output --- what else would you call the
output expressions of a node?

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ygor Degani 2009-08-20 15:13:57 Duplicated Keys in PITR
Previous Message Robert Haas 2009-08-20 14:22:38 Re: explain root element for auto-explain