From: | Kevin Grittner <kgrittn(at)ymail(dot)com> |
---|---|
To: | Gurjeet Singh <gurjeet(at)singh(dot)im> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Patch to send transaction commit/rollback stats to the stats collector unconditionally. |
Date: | 2014-07-02 19:49:27 |
Message-ID: | 1404330567.18289.YahooMailNeo@web122301.mail.ne1.yahoo.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
In preparing to push the patch, I noticed I hadn't responded to this:
Gurjeet Singh <gurjeet(at)singh(dot)im> wrote:
> Kevin Grittner <kgrittn(at)ymail(dot)com> wrote:
>> I have reviewed this patch, and think we should do what the patch
>> is trying to do, but I don't think the submitted patch would
>> actually work.
>
> Just curious, why do you think it won't work.
Because you didn't touch this part of the function:
/*
* Send partial messages. If force is true, make sure that any pending
* xact commit/abort gets counted, even if no table stats to send.
*/
if (regular_msg.m_nentries > 0 ||
(force && (pgStatXactCommit > 0 || pgStatXactRollback > 0)))
pgstat_send_tabstat(®ular_msg);
The statistics would not actually be sent unless a table had been
accessed or it was forced because the connection was closing.
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Joe Conway | 2014-07-02 19:52:51 | Re: Audit of logout |
Previous Message | Tom Lane | 2014-07-02 19:45:12 | Re: log_error_verbosity and unexpected errors |