From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | Michael Paesold <mpaesold(at)gmx(dot)at>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Log line prefix on win32 |
Date: | 2004-10-08 17:13:09 |
Message-ID: | 14017.1097255589@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> I was thinking of adding %z as an option to log_line prefix, so to get
> the current output you would do '%t %z'. I was not suggesting changing
> the %Z passed to strftime if they ask for timezone.
I think this is a bad idea, mainly because you couldn't easily get the
same output. It would be almost the same, except when you crossed a DST
boundary in between the two calls to strftime; in which case you'd get a
completely misleading result.
I believe that in the long run we will stop using the platform-specific
strftime at all, and go over to using just our own code, which makes
this not a permanent problem but just an artifact of the fact that we
haven't completely finished the process of absorbing src/timezone/.
So I'd rather not invent an API element simply because Windows' strftime
sucks.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Josh Berkus | 2004-10-08 17:18:27 | Re: plans for bitmap indexes? |
Previous Message | Yann Michel | 2004-10-08 17:10:53 | Re: plans for bitmap indexes? |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-10-08 17:38:06 | Re: Log line prefix on win32 |
Previous Message | Bruce Momjian | 2004-10-08 17:02:35 | Re: Log line prefix on win32 |