From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: make check in contrib |
Date: | 2011-04-25 15:22:49 |
Message-ID: | 14007.1303744969@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Apr 25, 2011 at 10:21 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> On Sun, Apr 24, 2011 at 7:18 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>>>> I noticed again that make check in contrib doesn't work, so here is a
>>>> patch to fix it.
>>> I think it might be more useful to have a check target that actually
>>> succeeds, even if it does nothing useful.
>> That argument seems a bit irrelevant to the proposed patch.
> How so?
The proposed patch is to fix it, not remove it. Surely that's more
useful than a no-op target.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Smith | 2011-04-25 15:26:33 | Re: fsync reliability |
Previous Message | Tom Lane | 2011-04-25 15:17:42 | Re: branching for 9.2devel |