Re: don't allocate HashAgg hash tables when running explain only

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Greg Stark <stark(at)mit(dot)edu>
Cc: Alexey Bashtanov <bashtanov(at)imap(dot)cc>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: don't allocate HashAgg hash tables when running explain only
Date: 2020-11-19 06:47:51
Message-ID: 13c493f8-f459-1798-0944-fb6dda92cb37@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 19/11/2020 07:20, Greg Stark wrote:
> On Wed, 18 Nov 2020 at 05:40, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>>
>> On 13/11/2020 18:10, Alexey Bashtanov wrote:
>>>> I would appreciate if someone could have a look at the patch attached,
>>> which makes executor skip initializing hash tables when doing explain only.
>>
>> Makes sense. Committed, thanks for the patch!
>
> Egads. That seems like a backpatchable bug fix to me. Have we been
> doing this all along?!

Yeah, I believe it's always been like that. Yeah, arguably it should be
backpatched. I felt conservative and didn't backpatch, but feel free to
do it if you think it should be.

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2020-11-19 06:59:42 Re: Should we document IS [NOT] OF?
Previous Message Tom Lane 2020-11-19 06:23:39 Re: Should we document IS [NOT] OF?