Re: pgbench regression test failure

Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
>> It could be as simple as putting the check-for-done at the bottom of the
>> loop not the top, perhaps.

> I agree that it is best if tests should work in all reasonable conditions,
> including a somehow overloaded host...

> I'm going to think about it, but I'm not sure of the best approach. In the
> mean time, ISTM that the issue has not been encountered (yet), so this is
> not a pressing issue. Maybe under -T > --aggregate-interval pgbench could
> go on over the limit if the log file has not been written at all, but that
> would be some kind of kludge for this specific test...

After another week of buildfarm runs, we have a few more cases of 3 rows
of output, and none of more than 3 or less than 1. So I went ahead and
pushed your patch. I'm still suspicious of these results, but we might
as well try to make the buildfarm green pending investigation of how
this is happening.

regards, tom lane