| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: meson oddities |
| Date: | 2023-01-19 20:37:15 |
| Message-ID: | 13893d09-e53e-9f98-2c1c-2d1c5c14c010@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11.01.23 12:05, Peter Eisentraut wrote:
> I think there is also an adjacent issue: The subdir options may be
> absolute or relative. So if you specify --prefix=/usr/local and
> --sysconfdir=/etc/postgresql, then
>
> config_paths_data.set_quoted('SYSCONFDIR', dir_prefix / dir_sysconf)
>
> would produce something like /usr/local/etc/postgresql.
>
> I think maybe we should make all the dir_* variables absolute right at
> the beginning, like
>
> dir_lib = get_option('libdir')
> if not fs.is_absolute(dir_lib)
> dir_lib = dir_prefix / dir_lib
> endif
>
> And then the appending stuff could be done after that, keeping the
> current code.
Here is a proposed patch. This should fix all these issues.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-meson-Make-all-subdirectory-variables-absolute.patch | text/plain | 5.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-01-19 20:45:49 | Re: meson oddities |
| Previous Message | Tom Lane | 2023-01-19 20:16:00 | Re: BF animal malleefowl reported an failure in 001_password.pl |