Re: pgsql-server/src/backend catalog/pg_proc.c nod ...

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Bruce Momjian - CVS <momjian(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql-server/src/backend catalog/pg_proc.c nod ...
Date: 2002-08-04 23:58:49
Message-ID: 13864.1028505529@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Joe Conway <mail(at)joeconway(dot)com> writes:
> The pg_proc problem was my fault -- sorry about that. Bruce's fix was
> correct.
> The equalfuncs.c problem was due to a bad merge -- the hunk got applied
> to RangeVar instead of RangeFunction.

> Attached is a patch to fix both files.

Patch applied.

> I cannot confirm it yet however
> because of unrelated compile issues. I've worked around these two
> (workarounds excluded from the patch):

> - make clean fails due to not finding contrib/earthdistance

contrib/earthdistance is still there according to my copy of CVS.
I believe that Marc split out that directory into a separate CVS module;
if you're using CVSup then this may suggest a problem with your cvsup
config?

> - make all fails due to undefined reference to `XLogDir'

This is breakage in Thomas' recent XLOG patch. I am strongly tempted
to revert that patch, given that neither Bruce nor I like it, but will
refrain for fear of getting Thomas ticked off at me ...

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2002-08-05 00:21:27 pgsql-server/src/backend/catalog pg_proc.c
Previous Message Tom Lane 2002-08-04 23:56:01 pgsql-server/src/backend/tcop postgres.c