| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [bug fix] Savepoint-related statements terminates connection |
| Date: | 2017-09-01 14:19:35 |
| Message-ID: | 13854.1504275575@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> I've added tests to the recent patch to show it works.
I don't think those test cases prove anything (ie, they work fine
on an unpatched server). With a backslash maybe they would.
> Any objection to me backpatching this, please say.
This patch makes me itch. Why is it correct for these three checks,
and only these three checks out of the couple dozen uses of isTopLevel
in standard_ProcessUtility, to instead do something else?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2017-09-01 14:29:04 | Re: pgbench: Skipping the creating primary keys after initialization |
| Previous Message | Daniel Gustafsson | 2017-09-01 14:14:25 | Re: Upcoming commit fest will begin soon |