Re: Clang 3.3 Analyzer Results

From: Kevin Grittner <kgrittn(at)ymail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "noloader(at)gmail(dot)com" <noloader(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Clang 3.3 Analyzer Results
Date: 2013-11-13 15:35:51
Message-ID: 1384356951.87538.YahooMailNeo@web162906.mail.bf1.yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> No, this isn't about test code vs production, it's about not bothering
> to free memory explicitly when a program is about to terminate.  Alvaro
> is suggesting that the proposed addition to pg_regress.c is just a waste
> of cycles.  IMO it's not that big a deal either way in this case, since
> it's just one line of code that isn't going to take too long.

Right.  IMV, it's easier in this case to silence the warnings for
all future static code analysis runs, by this tool or any other, by
fixing it rather than having this particular triviality resurface
to annoy anyone in the future.

Fix pushed to the master branch.

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Tom Lane 2013-11-13 15:37:22 Re: freeze cannot be finished
Previous Message Миша Тюрин 2013-11-13 15:29:45 freeze cannot be finished

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2013-11-13 15:59:22 Re: alter_table regression test problem
Previous Message Andrew Dunstan 2013-11-13 15:32:23 Re: additional json functionality