| From: | Kevin Grittner <kgrittn(at)ymail(dot)com> |
|---|---|
| To: | Kevin Grittner <kgrittn(at)ymail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Geoghegan <pg(at)heroku(dot)com>, "noloader(at)gmail(dot)com" <noloader(at)gmail(dot)com>, Tomas Vondra <tv(at)fuzzy(dot)cz>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Clang 3.3 Analyzer Results |
| Date: | 2013-11-12 13:44:52 |
| Message-ID: | 1384263892.88766.YahooMailNeo@web162906.mail.bf1.yahoo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
Kevin Grittner <kgrittn(at)ymail(dot)com> wrote:
> Logic error
> Stack address stored into global variable: 1
I took a look at this one, and it is a totally legitimate use, the
reason for which is explained with this comment:
/*
* check_stack_depth: check for excessively deep recursion
*
* This should be called someplace in any recursive routine that might possibly
* recurse deep enough to overflow the stack. Most Unixen treat stack
* overflow as an unrecoverable SIGSEGV, so we want to error out ourselves
* before hitting the hardware limit.
*/
Which raises the question: do these clang tools have any way to
record which "errors" have been established to be false positives,
so that they don't show up in subsequent runs. I know Valgrind has
that. Without such a capability, these tools don't seem very
valuable.
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2013-11-12 14:33:51 | Re: Clang 3.3 Analyzer Results |
| Previous Message | Kevin Grittner | 2013-11-12 13:18:58 | Re: Clang 3.3 Analyzer Results |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2013-11-12 14:19:19 | Re: Fast insertion indexes: why no developments |
| Previous Message | Kevin Grittner | 2013-11-12 13:18:58 | Re: Clang 3.3 Analyzer Results |