Re: pgsql: Fix blatantly broken record_image_cmp() logic for pass-by-value

Kevin Grittner <kgrittn(at)ymail(dot)com> wrote:

> I distilled it down to the simplest case I could find which
> failed to produce the warning; attached.

For a compiler which seems to like to generate warnings for really
esoteric cases, clang falls down rather badly on uninitialized
variables -- at least on the package for Ubuntu 12.10.  It does not
complain at all about this:

int warning_test(int a);
int warning_test(int a)
{
    int result;

    if (a == 1)
        result = 1;

    return result;
}

I assume that everyone here agrees that merits a warning?

Bug reports filed.

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company