Re: [COMMITTERS] pgsql: Revive line type

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Revive line type
Date: 2013-10-11 00:06:53
Message-ID: 1381450013.5264.2.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, 2013-10-10 at 10:51 -0400, Robert Haas wrote:
> On Wed, Oct 9, 2013 at 10:43 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> > Revive line type
>
> Kevin just pointed out to me that there are a bunch of buildfarm
> failures. I'm looking at the ones that are attributable to shared
> memory, but there seem to be some problems with this patch as well.
> Check out brolga, for example.

OK, I fixed the obvious issue with the geometry test. The line test is
now failing because of "negative zero", which could be addressed with an
alternative expected file like in the case of geometry, and also because
of a rounding issue. I'm not sure yet whether the latter is just
another platform difference, an unfortunately example case, or an actual
bug.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2013-10-11 00:23:14 pgsql: Remove maintainer-check target, fold into normal build
Previous Message Peter Eisentraut 2013-10-11 00:00:09 pgsql: Update regression tests for line type patch

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2013-10-11 00:23:14 pgsql: Replace duplicate_oids with Perl implementation
Previous Message Robert Haas 2013-10-11 00:03:09 Re: dynamic shared memory: wherein I am punished for good intentions