Re: tsearch2 regression test path problem

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: tsearch2 regression test path problem
Date: 2004-10-17 22:53:17
Message-ID: 13801.1098053597@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> I'm not sure if there is some nicely portable way around this. Any
> suggestions?

Now that I think about it, we already had an open issue with tsearch2,
which is that the way it's doing this, a relocatable installation is
impossible.

I think the most reasonable fix is to change the readstoplist() function
so that it will accept relative paths and interpret them as relative to
the "share" directory (which is $datadir as seen by the Makefiles; we
can get the correct runtime location from get_share_path). Then we can
just put "contrib/english.stop" into the pg_ts_dict entry and not have
to interpolate any build-time path at all.

Will see about doing this.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2004-10-17 23:10:12 Re: tsearch2 regression test path problem
Previous Message Troels Arvin 2004-10-17 22:24:09 Re: DETERMINISTIC as synonym for IMMUTABLE