Re: postgresql-10.0/src/bin/psql/mainloop.c:465: suspicious condition ?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Binderman <dcb314(at)hotmail(dot)com>
Cc: "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: postgresql-10.0/src/bin/psql/mainloop.c:465: suspicious condition ?
Date: 2017-10-06 15:07:28
Message-ID: 13799.1507302448@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

David Binderman <dcb314(at)hotmail(dot)com> writes:
> postgresql-10.0/src/bin/psql/mainloop.c:461] -> [postgresql-10.0/src/bin/psql/mainloop.c:465]: (warning) Opposite inner 'if' condition leads to a dead code block.

Huh ... that code's been like that since 2006. Odd that nothing's
noticed the dead-ness before. What tool were you using?

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message David Binderman 2017-10-06 15:10:29 Re: postgresql-10.0/src/bin/psql/mainloop.c:465: suspicious condition ?
Previous Message Tom Lane 2017-10-06 14:54:21 Re: BUG #14845: postgres_fdw and mysql_fdw can cause crash of instance