From: | Kevin Grittner <kgrittn(at)ymail(dot)com> |
---|---|
To: | Noah Misch <noah(at)leadboat(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Materialized views WIP patch |
Date: | 2013-08-18 21:28:35 |
Message-ID: | 1376861315.25123.YahooMailNeo@web162902.mail.bf1.yahoo.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Kevin Grittner <kgrittn(at)ymail(dot)com> wrote:
> Noah Misch <noah(at)leadboat(dot)com> wrote:
>> Also, could you explain the use of RelationCacheInvalidateEntry()
>> in ExecRefreshMatView()? CacheInvalidateRelcacheByRelid()
>> followed by CommandCounterIncrement() is the typical pattern;
>> this is novel. I suspect, though, neither is necessary now that
>> the relcache does not maintain populated status based on a fork
>> size reading.
>
> Yeah, that was part of the attempt to support unlogged materialized
> views while also not returning bogus results if the view had not
> been populated, using heap file size. I agree that this line can
> just come out. If there are no objections real soon now, I will
> remove it in master and the 9.3 branch before the release
> candidate.
Done.
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2013-08-18 21:30:29 | Re: warning in code while building on windows |
Previous Message | Alvaro Herrera | 2013-08-18 21:08:49 | Re: warning in code while building on windows |