Re: timeline signedness

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: timeline signedness
Date: 2013-08-15 03:34:35
Message-ID: 1376537675.11756.6.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 2013-08-14 at 16:20 +0300, Heikki Linnakangas wrote:
> On 13.08.2013 14:31, Peter Eisentraut wrote:
> > On Wed, 2013-08-07 at 21:55 -0400, Peter Eisentraut wrote:
> >> WAL timelines are unsigned 32-bit integers everywhere, except the
> >> replication parser (replication/repl_gram.y and
> >> replication/repl_scanner.l) treats them as signed 32-bit integers. It's
> >> obviously a corner case, but it would be prudent to be correct about
> >> this. It should be easy to fix in those grammar files.
>
> +1
>
> > Here is a patch to fix this.
>
> If I'm reading this correctly, timeline 0 no longer throws an error with
> this patch.

Fixed that.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2013-08-15 03:35:45 Re: updatable/deletable terminology
Previous Message Etsuro Fujita 2013-08-15 02:17:15 Re: Incorrect information in src/backend/optimizer/README