Re: [HACKERS] object_classes array is broken, again

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>, Jaimin Pan <jaimin(dot)pan(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: [HACKERS] object_classes array is broken, again
Date: 2015-07-20 13:49:13
Message-ID: 13760.1437400153@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Any opinions on this idea? I don't like it all that much, but it's
> plenty effective.

I don't like it much either.

What about adding StaticAsserts that lengthof() the relevant constant
arrays is equal to MAX_OCLASS? (Or other similar ways of checking
that they have the right number of entries.)

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message gregoire.hubert 2015-07-20 15:58:38 BUG #13506: jsonb || operator does not work
Previous Message Alvaro Herrera 2015-07-20 12:29:28 Re: Lack of Sanity Checking in file 'pctcl.c' for PostgreSQL 9.4.x

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2015-07-20 14:15:02 Re: All-zero page in GIN index causes assertion failure
Previous Message sudalai 2015-07-20 13:40:22 Re: First Aggregate Funtion?