| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP: log query in auto-explain |
| Date: | 2009-11-22 20:48:08 |
| Message-ID: | 13756.1258922888@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> I put the attached together a while ago and neglected to send it.
> Basically it includes the text of the query being explained in the
> explain output.
I'm pretty certain this will dump core in some contexts --- you should
not assume that sourceText is always available.
Should we be worried about security implications of displaying the query
text?
> I think it's more important to include the query text when using
> auto_explain than in other explain uses, which is why I did it this way.
> But I could be persuaded that we should always include it.
I think this is just useless noise in every other case.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Scott Marlowe | 2009-11-22 20:48:36 | Re: Updating column on row update |
| Previous Message | Thom Brown | 2009-11-22 20:32:58 | Re: Updating column on row update |