Re: Removing typename from A_Const (was: Empty arrays with ARRAY[])

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Brendan Jurd escribi:
>> Here's my attempt to remove the typename field from A_Const. There
>> were a few places (notably flatten_set_variable_args() in guc.c, and
>> typenameTypeMod() in parse_type.c) where the code expected to see an
>> A_Const with a typename, and I had to adjust for an A_Const within a
>> TypeCast. Nonetheless, there was an overall net reduction of 34 lines
>> of code, so I think this was a win.

> Do say ... why don't we do away with A_Const altogether and just replace
> it with Value? After this patch, I don't see what's the difference.

They're logically different things, and after I get done putting a parse
location field into A_Const, they'll still be physically different too.

regards, tom lane