From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Add %z support to elog/ereport? |
Date: | 2014-01-23 16:25:56 |
Message-ID: | 13752.1390494356@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> I was wondering more about the nature of the runtime check than the fact
> that it's a runtime check at all... E.g. snprintf.c simply skips over
> unknown format characters and might not have been detected as faulty on
> 32bit platforms by that check. Which might be considered a good thing :)
Oh ... gotcha. Yeah, it's possible that snprintf would behave in a way
that masks the fact that it doesn't really recognize the "z" flag, but
that seems rather unlikely to me. More likely it would abandon processing
the %-sequence on grounds it's malformed.
I will try the patch on my old HPUX dinosaur, which I'm pretty sure
does not know "z", and verify this is the case.
Also, I'm guessing Windows' version of snprintf doesn't have "z" either.
Could someone try the patch's configure test program on Windows and see
what the result is?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Florian Pflug | 2014-01-23 16:40:52 | Re: Passing "direct" args of ordered-set aggs to the transition function |
Previous Message | Heikki Linnakangas | 2014-01-23 16:22:18 | Re: GIN improvements part2: fast scan |