Re: pg_filedump 9.3: checksums (and a few other fixes)

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Satoshi Nagayasu <snaga(at)uptime(dot)jp>
Cc: Josh Kupershmidt <schmiddy(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_filedump 9.3: checksums (and a few other fixes)
Date: 2013-07-08 17:28:25
Message-ID: 1373304505.30779.5.camel@jdavis
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 2013-07-05 at 22:43 -0700, Jeff Davis wrote:
> On Sat, 2013-07-06 at 10:30 +0900, Satoshi Nagayasu wrote:
> > Hi,
> >
> > It looks fine, but I have one question here.
> >
> > When I run pg_filedump with -k against a database cluster which
> > does not support checksums, pg_filedump produced checksum error as
> > following. Is this expected or acceptable?
>
> Thank you for taking a look. That is expected, because there is not a
> good way to determine whether the file was created with checksums or
> not. So, we rely on the user to supply (or not) the -k flag.

I see this patch is still "waiting on author" in the CF. Is there
something else needed from me, or should we move this to "ready for
committer"?

Regards,
Jeff Davis

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2013-07-08 17:32:26 Re: Improving avg performance for numeric
Previous Message Josh Berkus 2013-07-08 17:17:56 Re: Improving avg performance for numeric