Re: [PATCHES] plperl and pltcl installcheck targets

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] plperl and pltcl installcheck targets
Date: 2005-05-11 18:32:38
Message-ID: 13727.1115836358@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Tom Lane wrote:
>> I think this would require a small addition to the pg_regress script
>> to make it configurable as to which PL to install, instead of always
>> installing plpgsql, but that seems like a reasonable thing to do.

> I'm not sure why it would matter having it there. I would just make the
> first test to load the language in question - pretty much this, right?

> CREATE FUNCTION "plperl_call_handler" () RETURNS language_handler AS
> '$libdir/plperl' LANGUAGE C;
> CREATE TRUSTED LANGUAGE "plperl" HANDLER "plperl_call_handler";
> CREATE LANGUAGE "plperlu" HANDLER "plperl_call_handler";

The point is that I'd rather test createlang than duplicate it.

(In the back of my mind also is that running createlang is a waste of
time for the contrib tests, and so it'd be nice if pg_regress didn't
load any PL unless told to.)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-05-11 19:21:42 Re: Oracle Style packages on postgres
Previous Message Andrew Dunstan 2005-05-11 18:04:09 Re: 7.3.10 working

Browse pgsql-patches by date

  From Date Subject
Next Message John Hansen 2005-05-11 18:58:54 Re: lastval()
Previous Message Bruce Momjian 2005-05-11 18:07:12 Re: pg_autovacuum micro patch to display database name when