Re: Bugfix and new feature for PGXS

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: cedric(at)2ndquadrant(dot)com
Cc: pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, Craig Ringer <craig(at)2ndquadrant(dot)com>
Subject: Re: Bugfix and new feature for PGXS
Date: 2013-06-20 03:26:21
Message-ID: 1371698781.13762.48.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 2013-06-19 at 20:58 +0200, Cédric Villemain wrote:
> I believe he answered the proposal to put all headers on the same flat
> directory, instead of a tree.

The headers are used as

#include "hstore.h"
#include "ltree.h"
etc.

in the existing source code.

If you want to install the for use by others, you can do one of three
things:

1) Install them into $(pg_config --includedir-server), so other users
will just include them in the same way as shown above.

2) Install them in a different directory, but keep the same #include
lines. That would require PGXS changes, perhaps a new pg_config option,
or something that produces the right -I option to find them.

3) Install them in a different directory and require a different
#include line. But then you have to change the existing uses as well,
which would probably require moving files around.

Both 2 and 3 require a lot of work, possibly compatibility breaks, for
no obvious reason.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message fabriziomello 2013-06-20 03:33:42 Re: [PATCH] add long options to pgbench (submission 1)
Previous Message Satoshi Nagayasu 2013-06-20 03:26:20 Re: Add visibility map information to pg_freespace.