Re: [PATCH] Remove useless USE_PGXS support in contrib

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Remove useless USE_PGXS support in contrib
Date: 2013-06-19 03:04:48
Message-ID: 1371611088.13762.27.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 2013-06-17 at 11:41 +0200, Dimitri Fontaine wrote:
> I agree that having both cases (sections) in the Makefile is a bad
> idea.
> Still, why should we keep the in-tree build instructions?
>
> Would it be possible instead to instruct PGXN to work with a non
> installed server source tree? And how much do we need that really?

We could do something like

PG_CONFIG = fake_intree_pg_config
PGXS := $(shell $(PG_CONFIG) --pgxs)
include $(PGXS)

where fake_intree_pg_config is a purpose-built shell script that points
to the right places inside the source tree.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2013-06-19 03:11:32 Re: Review: UNNEST (and other functions) WITH ORDINALITY
Previous Message Peter Eisentraut 2013-06-19 02:58:15 Re: [PATCH] Remove useless USE_PGXS support in contrib