Re: [PATCH] Remove useless USE_PGXS support in contrib

----- Original Message -----

> From: Peter Eisentraut <peter_e(at)gmx(dot)net>
> To: pgsql-hackers(at)postgresql(dot)org
> Cc:
> Sent: Thursday, 13 June 2013 12:16 PM
> Subject: [HACKERS] [PATCH] Remove useless USE_PGXS support in contrib
>
>T his has served no purpose except to
>
> 1. take up space
> 2. confuse users
> 3. produce broken external extension modules that take contrib as an example
> 4. break builds of PostgreSQL when users try to fix 3. by exporting USE_PGXS

Agree, only if we consider these contrib module is always gonna deployed with the postgresql.
But, what if user going to install such module elsewhere i.e. not from contrib directory of pg source.
I this way Makefile should different, right? 

We need to makefile code should uniform to exclude any confusion to user.

if space is not such dominant, we can add code at the top of make file to avoid confusion of user to export USE_PGXS as follow  

ifndef USE_PGXS
top_builddir = ../..
makefile_global = $(top_builddir)/src/Makefile.global
ifeq "$(wildcard $(makefile_global))" ""
USE_PGXS = 1 
endif

/* remaining code as it is */*

Regards,
Amul Sul