| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org, pgsql-release(at)postgresql(dot)org, Noah Misch <noah(at)leadboat(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURR |
| Date: | 2022-02-09 05:44:42 |
| Message-ID: | 1370502.1644385482@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Tue, Feb 08, 2022 at 05:43:34PM -0800, Andres Freund wrote:
>> It's stamped, not tagged, so we could send out new tarballs. Or we could skip
>> a release number. IIRC we had to do something along those lines before.
> It does not matter now, but the release is stamped and tagged.
Yeah, I see no need to do anything about this on an emergency
basis.
>> What do you mean with detect here?
> Well, we would not be able to see that something is stuck by default,
> but Noah has just answered to my question by mentioning wait_timeout
> in the buildfarm configuration.
The buildfarm's wait_timeout option isn't that helpful here, because
when it triggers, the client just goes belly-up *with no report*.
So even if the CCA animals had it on, you'd not notice unless you
started to wonder why they'd not reported lately.
I think that's a bug that ought to be fixed. I do agree that
wait_timeout ought to be finite by default, too.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2022-02-09 13:13:53 | pgsql: Free temporary memory when reading TOC |
| Previous Message | Noah Misch | 2022-02-09 05:41:41 | Re: pgsql: Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURR |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2022-02-09 05:52:20 | Re: decoupling table and index vacuum |
| Previous Message | Noah Misch | 2022-02-09 05:41:41 | Re: pgsql: Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURR |