| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Subject: | Re: remove unneeded pstrdup in fetch_table_list |
| Date: | 2021-01-14 05:21:02 |
| Message-ID: | 1370092.1610601662@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Thu, Jan 14, 2021 at 01:17:57AM +0000, Hou, Zhijie wrote:
>>>> Thanks. I am thinking to backpatch this even though there is no
>>>> problem reported from any production system. What do you think?
> text_to_cstring() indeed allocates a new string, so the extra
> allocation is useless. FWIW, I don't see much point in poking at
> the stable branches here.
Yeah, unless there's some reason to think that this creates a
meaningful memory leak, I wouldn't bother back-patching.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2021-01-14 05:23:23 | Re: Single transaction in the tablesync worker? |
| Previous Message | Michael Paquier | 2021-01-14 05:18:45 | Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly |