Re: visibilitymap_set and checksums

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: visibilitymap_set and checksums
Date: 2013-05-29 16:53:24
Message-ID: 1369846404.9884.0.camel@jdavis-laptop
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 2013-05-24 at 22:16 +0100, Simon Riggs wrote:
> I think its perfectly understandable. Robert, Jeff and I discussed
> that for a while before we passed it. I'm still not happy with it, and
> think its a pretty confusing section of code with multiple paths
> through it, but I just can't see a better way.

Agreed on all counts. Comment patches are welcome, of course.

I'll add that if we remove PD_ALL_VISIBLE, this complexity disappears.

Regards,
Jeff Davis

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2013-05-29 17:11:13 Re: getting rid of freezing
Previous Message Abhishek Rai 2013-05-29 16:36:10 Re: pg_stat_replication when standby is unreachable