From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | "Brendan Jurd" <direvus(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: [PATCHES] Text <-> C string |
Date: | 2008-03-28 19:26:21 |
Message-ID: | 13684.1206732381@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
"Brendan Jurd" <direvus(at)gmail(dot)com> writes:
> On 26/03/2008, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> There are no textout/textin calls left, but I may have missed some
>> places that were doing it the hard way with direct palloc/memcpy
>> manipulations. It might be worth trolling all the VARDATA() references
>> to see if any more are easily replaceable.
> I think there are perhaps a dozen such sites, and I hope to submit a
> cleanup patch that gets rid of these soon.
> I did come across one site I'm not sure about in utils/adt/xml.c:291
I intentionally didn't touch xml.c, nor anyplace that is not dealing
in text, even if it happens to be binary-compatible with text.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Brendan Jurd | 2008-03-28 19:40:46 | Re: [PATCHES] Text <-> C string |
Previous Message | Simon Riggs | 2008-03-28 19:09:59 | Re: [PATCHES] Implemented current_query |
From | Date | Subject | |
---|---|---|---|
Next Message | Brendan Jurd | 2008-03-28 19:40:46 | Re: [PATCHES] Text <-> C string |
Previous Message | Simon Riggs | 2008-03-28 19:09:59 | Re: [PATCHES] Implemented current_query |