boolean abuse in geo_ops.c

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers(at)postgresql(dot)org
Subject: boolean abuse in geo_ops.c
Date: 2013-04-23 01:51:30
Message-ID: 1366681890.15557.2.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The function

static char *
path_encode(bool closed, int npts, Point *pt)

is actually occasionally passed -1 as its first parameter to mean
something like "neither" or "don't print any delimiters". That doesn't
seem like good style. Maybe this should be split off into another bool
parameter named delimited or something? Or the argument could be made
into an integer.

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2013-04-23 01:55:06 Re: GSOC Student Project Idea
Previous Message Jeff Davis 2013-04-23 01:35:38 Re: Enabling Checksums