From: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_basebackup check vs Windows file path limits |
Date: | 2023-11-11 13:00:00 |
Message-ID: | 13663265-cac2-ec5d-d378-0dd44a895f8e@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello Andrew,
08.07.2023 18:52, Andrew Dunstan wrote:
>> Since this test is passing on HEAD which has slightly shorter paths, I'm wondering if we should change this:
>>
>> rename("$pgdata/pg_replslot", "$tempdir/pg_replslot")
>> or BAIL_OUT "could not move $pgdata/pg_replslot";
>> dir_symlink("$tempdir/pg_replslot", "$pgdata/pg_replslot")
>> or BAIL_OUT "could not symlink to $pgdata/pg_replslot";
>>
>> to use the much shorter $sys_tempdir created a few lines below.
>>
> Pushed a tested fix along those lines.
>
Today I've started up my Windows VM to run some tests and discovered a test
failure caused by that fix (e213de8e7):
>meson test
Ok: 246
Expected Fail: 0
Fail: 1
Unexpected Pass: 0
Skipped: 14
Timeout: 0
...\010_pg_basebackup\log\regress_log_010_pg_basebackup.txt contains:
[04:42:45.321](0.291s) Bail out! could not move
T:\postgresql\build/testrun/pg_basebackup/010_pg_basebackup\data/t_010_pg_basebackup_main_data/pgdata/pg_replslot
With a diagnostic print added before rename() in 010_pg_basebackup.pl, I see:
rename("T:\postgresql\build/testrun/pg_basebackup/010_pg_basebackup\data/t_010_pg_basebackup_main_data/pgdata/pg_replslot",
"C:\Users\User\AppData\Local\Temp\fGT76tZUWr/pg_replslot")
That is, I have the postgres source tree and the user tempdir placed on
different disks.
perldoc on rename() says that it usually doesn't work across filesystem
boundaries, so I think it's not a Windows-specific issue.
Best regards,
Alexander
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2023-11-11 15:18:51 | Re: pg_basebackup check vs Windows file path limits |
Previous Message | John Naylor | 2023-11-11 12:38:59 | Re: autovectorize page checksum code included elsewhere |