Re: [COMMITTERS] pgsql: Move pqsignal() to libpgport.

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Hackers (PostgreSQL)" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Move pqsignal() to libpgport.
Date: 2013-03-17 17:52:02
Message-ID: 1363542722.2888.26.camel@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sun, 2013-03-17 at 16:06 +0000, Tom Lane wrote:
> Move pqsignal() to libpgport.
>
> We had two copies of this function in the backend and libpq, which was
> already pretty bogus, but it turns out that we need it in some other
> programs that don't use libpq (such as pg_test_fsync). So put it where
> it probably should have been all along. The signal-mask-initialization
> support in src/backend/libpq/pqsignal.c stays where it is, though, since
> we only need that in the backend.
>

Hi,

When I try to compile HEAD right after this commit, I have this issue
with pg_receivexlog:

pg_receivexlog.c: In function ‘main’:
pg_receivexlog.c:425:11: error: ‘SIGINT’ undeclared (first use in this
function)
pg_receivexlog.c:425:11: note: each undeclared identifier is reported
only once for each function it appears in

The attached patch fixes this. Not sure it's the right fix though...

--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com

Attachment Content-Type Size
signal.patch text/x-patch 368 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2013-03-17 18:11:53 pgsql: Fix inclusions in pg_receivexlog.c.
Previous Message Tom Lane 2013-03-17 16:06:59 pgsql: Move pqsignal() to libpgport.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-03-17 18:13:08 Re: [COMMITTERS] pgsql: Move pqsignal() to libpgport.
Previous Message Tom Lane 2013-03-17 16:06:59 pgsql: Move pqsignal() to libpgport.