Re: Materialized View patch broke pg_dump

From: Kevin Grittner <kgrittn(at)ymail(dot)com>
To: Bernd Helmle <mailings(at)oopsware(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Materialized View patch broke pg_dump
Date: 2013-03-06 14:57:13
Message-ID: 1362581833.88172.YahooMailNeo@web162903.mail.bf1.yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bernd Helmle <mailings(at)oopsware(dot)de> wrote:

> It looks like the recent matview patch broke pg_dump in a way, which make it
> impossible to dump 9.1 and 9.2 databases.
>
> it fails with
>
> pg_dump: [Archivierer (DB)] query failed: ERROR:  function
> pg_relation_is_scannable(oid) does not exist
>
> Looking into this issue, it seems the version check in getTables() of pg_dump.c
> is wrong. Shouldn't the check be
>
> if (fout->remoteVersion >= 90300)
> {
>
> }
>
> since this is where pg_relation_is_scannable() is introduced?

Right.  Will fix.

--
Kevin Grittner
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2013-03-06 15:36:19 Re: Optimizing pglz compressor
Previous Message Kevin Grittner 2013-03-06 14:53:20 Re: Materialized views WIP patch