| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | sugita(at)sra(dot)co(dot)jp |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Rejection of the smallest int8 |
| Date: | 2001-11-21 15:06:09 |
| Message-ID: | 13599.1006355169@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
sugita(at)sra(dot)co(dot)jp writes:
> Attached is a patch to accept the smallest value of int8.
This has been proposed before. The problem with it is that it's
not portable: the C standard does not specify the direction of rounding
of integer division when the dividend is negative. So the test
inside the loop that tries to detect overflow would be likely to fail
on some machines.
If you can see a way around that, we're all ears ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Cramer | 2001-11-21 15:21:29 | Benchmarks |
| Previous Message | Tatsuo Ishii | 2001-11-21 15:05:42 | Re: Regression tests need updating... |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2001-11-21 15:12:02 | Re: [PATCHES] Version checking when loading psql |
| Previous Message | Patrick Welche | 2001-11-21 12:25:55 | Re: [PATCHES] PQescapeBytea documentation patch |