Re: Refactor to split nodeAgg.c?

Jeff Davis <pgsql(at)j-davis(dot)com> writes:
> I was going to rebase my HashAgg patch, and got some conflicts related
> to the grouping sets patch. I could probably sort them out, but I think
> that may be the tipping point where we want to break up nodeAgg.c into
> nodeSortedAgg.c and nodeHashAgg.c, and probably a common file as well.

> This would also (I hope) be convenient for Simon and David Rowley, who
> have been hacking on aggregates in general.

> Anyone see a reason I shouldn't give this a try?

As with the discussion about pgbench, it's hard to opine about this
without seeing a concrete refactoring proposal. But if you want to
try, now, very early in the dev cycle, would be the best time to try.

regards, tom lane