| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Assertion failure on UNLOGGED VIEW and SEQUENCE |
| Date: | 2011-02-18 19:39:17 |
| Message-ID: | 13585.1298057957@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Fri, Feb 18, 2011 at 2:17 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> +1 for where you put the tests, but I don't think
>> ERRCODE_SYNTAX_ERROR is an appropriate errcode. I'd go with
>> FEATURE_NOT_SUPPORTED for both, I think.
> I hesitate to use FEATURE_NOT_SUPPORTED for something that's
> nonsensical anyway. I picked SYNTAX_ERROR after some scrutiny of what
> I believe to be parallel cases, such as EXPLAIN (FOO) SELECT 1 and
> CREATE TABLE t AS SELECT 1 INTO me.
[ shrug... ] I don't care enough to argue about it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-02-18 19:41:26 | Re: using a lot of maintenance_work_mem |
| Previous Message | Andrew Dunstan | 2011-02-18 19:35:58 | Re: SR standby hangs |