From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | [PATCH] unified frontend support for pg_malloc et al and palloc/pfree mulation (was xlogreader-v4) |
Date: | 2013-01-09 11:27:08 |
Message-ID: | 1357730830-25999-1-git-send-email-andres@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
As promised here's a patch to provide palloc emulation for frontend-ish
environments.
The patch:
- makes palloc() into a real function so CurrentMemoryContext doesn't
need to be provided
- provides common pg_(malloc,malloc0, realloc, strdup, free) wrappers
and removes various versions of those across different utilities
- removes ugly palloc redefinery for frontend use of backend code (dirmod.c)
Controversial/Unclear things:
- palloc[0] are currently copies of the MemoryContextAlloc[Zero]
functions to preclude performance regressions, imo the level of
duplication is ok though
- the common memory management is implemented in [pg]port/palloc.[ch], I
am not too happy with the name and location
- pgport/palloc.c is only built in the backend, not sure if there is a
nicer way to do this from a make POV
- the different versions of pg_malloc et al used different error
signaling methods, I've settled on
fprintf(stderr, _("out of memory\n"));
exit(EXIT_FAILURE);
Results in a nice net removal of code:
37 files changed, 218 insertions(+), 621 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2013-01-09 11:27:09 | [PATCH 1/2] Provide a common malloc wrappers and palloc et al. emulation for frontend'ish environs |
Previous Message | Simon Riggs | 2013-01-09 11:26:51 | Re: Performance Improvement by reducing WAL for Update Operation |